ROM on PinnedH2O with geometric transformation #304
Merged
siuwuncheung merged 5 commits intoROMFPMDfrom Feb 12, 2025
Merged
Conversation
jeanlucf22
reviewed
Feb 11, 2025
| #include <boost/program_options.hpp> | ||
| namespace po = boost::program_options; | ||
|
|
||
| double calculate_bondlength(const double atom1[3], const double atom2[3]) |
Collaborator
There was a problem hiding this comment.
as discussed, this and other functions below should be moved to another file
Collaborator
There was a problem hiding this comment.
but it could be done later, as part of MD implementation
jeanlucf22
approved these changes
Feb 11, 2025
oseikuffuor1
approved these changes
Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.